Allow async functions in the Vercel edge middleware integration #9334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vercel's Edge Middleware allows async functions so should the Astro wrapper.
🦋 Changeset detectedLatest commit: 5ba92f1 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: integration
lilnasy
reviewed
Dec 6, 2023
lilnasy
reviewed
Dec 6, 2023
lilnasy
reviewed
Dec 6, 2023
lilnasy
reviewed
Dec 6, 2023
Co-authored-by: Florian Lefebvre <[email protected]>
Co-authored-by: Arsh <[email protected]>
|
Should I squash these commits into one? Does it matter? |
bluwy
approved these changes
Dec 7, 2023
|
You don't have to squash them, when we merge the PR it will be squashed by GitHub. |
|
Hey @bluwy @lilnasy @florian-lefebvre I just want to say thanks for making my first PR with Astro very straightforward. This has been my best developer experience FOSS or not. Period. 👏👏😊 |
florian-lefebvre
approved these changes
Dec 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Vercel's Edge Middleware allows async functions so should the Astro wrapper.
Note: I bumped the minor version in this commit. Was I supposed to do that? It wasn't clear in the CONTRIBUTE.md
Testing
No tests needed. This is a very small change that doesn't break anything. The
awaitkeyword in JavaScript waits for a Promise to resolve, if it is a Promise. Otherwise,awaitreturns the value it's being called on.Docs
No docs added. This is just a bugfix.